Re: git cherry(pick) dumps core

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 30, 2010, 13:32 UTC
Message-ID: <20100430133228.GA1620@progeny.tock>
In-Reply-To: <20100429202139.GW10879@inner.home.ulmdo.de>

Andreas Krey wrote:

> On Thu, 29 Apr 2010 14:49:36 +0000, Jonathan Nieder wrote:

>> Thanks for the report.  What encoding were you using?  (You can check
>> with ‘git cat-file commit <revision you were trying to cherry-pick>’.)
>
> Actually, it was both UTF-8, both by the defaults in get_message():

[...]

> There being two different incarnations of iconv on this machine
> isn't making anything easier. :-( Will report when I find out
> what's wrong here. utf8 should be pretty universally known by now.

Yes, the problem is that the to and from encodings match. I hadn’t realized so before, but iconv doesn’t like that on some platforms (e.g., Solaris).

Since this is the usual case, we should probably check for it like git mailinfo does instead of waiting for iconv to fail.

Jonathan