Re: [PATCH v2 2/3] pretty: make %H/%h dependent on --abbrev[-commit]
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Apr 26, 2010, 03:41 UTC
- Message-ID
- <20100426034135.GB30544@progeny.tock>
- In-Reply-To
- <20100426033813.GA30544@progeny.tock>
Jonathan Nieder wrote:
> Jeff King wrote: >> On Sun, Apr 25, 2010 at 10:11:37PM -0500, Jonathan Nieder wrote:
Show 22 quoted lines
>>> +static void abbreviate_commit_hashes(char *fmt)
>>> +{
>>> + char *p;
>>> + for (p = fmt; p != NULL; p = strchr(p + 1, '%')) {
>>> + p++;
>>> + switch (*p) {
>>> + case 'H':
>>> + *p = 'h';
>>> + break;
>>> + case 'P':
>>> + *p = 'p';
>>> + break;
>>> + case 'T':
>>> + default:
>>> + break;
>>> + }
>>> + }
>>> +}
>>
>> You parse '%%H' incorrectly.
>
> I’m pretty sure I don’t.Aggh, I see it now. The first line should be
for (p = strchr(fmt, '%'); ...
as I would have noticed with even a little testing.
Sorry for the nonsense. Jonathan