Re: [PATCH 0/5] gitweb: Miscellaneous improvements, in preparation for caching support

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 25, 2010, 11:45 UTC
Message-ID: <201004251346.01183.jnareb@gmail.com>
In-Reply-To: <20100425092035.GO3563@machine.or.cz>

Petr Baudis wrote:

Show 11 quoted lines

> On Sat, Apr 24, 2010 at 03:46:25PM +0200, Jakub Narebski wrote:
> > Jakub Narebski (5):
> >       gitweb: Move generating page title to separate subroutine
> >       gitweb: Add custom error handler using die_error
> >       gitweb: Use nonlocal jump instead of 'exit' in die_error
> >       gitweb: href(..., -path_info => 0|1)
> >       Export more test-related variables when running external tests
> > 
> >  gitweb/gitweb.perl |   69 ++++++++++++++++++++++++++++++++++++++--------------
> >  t/test-lib.sh      |    3 ++
> >  2 files changed, 53 insertions(+), 19 deletions(-)

> >  mode change 100644 => 100755 t/test-lib.sh

Ooops, the mode change was accidental.

> 
> Except the last one, I don't think the patches bring something useful
> in on their own so ordinarily they would probably have to be a part of
> some series that makes use of them, but there's no harm done either.

Actually "gitweb: Use nonlocal jump instead of 'exit' in die_error" could in theory improve performance of gitweb on mod_perl, but I have not benchmarked it...

-- 
Jakub Narebski
Poland