Re: [PATCH] Documentation/Makefile: fix interrupted builds of user-manual.xml
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Apr 22, 2010, 10:24 UTC
- Message-ID
- <20100422102254.GA701@progeny.tock>
- In-Reply-To
- <FA4A6177-AB3E-4C5C-8042-1BFBAE09528B@pobox.com>
Chris Johnsen wrote:
> On 2010 Apr 21, at 20:18, Jonathan Nieder wrote:
Show 6 quoted lines
>> user-manual.html: user-manual.xml >> - $(QUIET_XSLTPROC)xsltproc $(XSLTOPTS) -o $@ $(XSLT) $< >> + $(QUIET_XSLTPROC)$(RM) $@+ $@ && \ >> + xsltproc $(XSLTOPTS) -o $@+ $(XSLT) $< && \ >> + mv $@+ $@ >>
[...]
> I suppose it is obvious enough what is going on in this in this > second hunk, but there is no mention of this change in the commit > message. Is this hunk due to a similar problem with xsltproc? Or > maybe this is just "defensive coding"?
xsltproc indeed has the same problem, as I learned while testing the first hunk. Thanks for asking.
Sorry for the incomplete explanation before. Jonathan