git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1304,t2007: quell output to stdout and stderr

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 21, 2010, 15:12 UTC
Message-ID
<20100421151236.GB8726@progeny.tock>
In-Reply-To
<4BCF1160.6020304@drmicha.warpmail.net>
Michael J Gruber wrote:
> I don't think it's OK to exit or test_done
> from within test_expect_something, is it?

exit: the consequences are the same whether you’re in a test or not. Either way, it’s bad. I think the intent of that ‘exit’ was to make a good effort to set up for the next test and skip the test if that didn’t work, which is a bit old-fashioned. Emptying the index before the checkout would make it like that the setup should not fail even if some related bug resurfaces.

test_done: not sure what would happen. Indeed, it doesn’t sound like a very sane thing to do. :)

Jonathan
Previous: Michael J GruberNext: Michael J Gruber
Message 4 of 6 in “t1304,t2007: quell output to stdout and stderr”
  1. t1304,t2007: quell output to stdout and stderrMichael J Gruber, Apr 21, 2010
  2. Jonathan NiederApr 21, 2010
  3. Michael J GruberApr 21, 2010
  4. Jonathan NiederApr 21, 2010
  5. t1304,t2007: quell output to stdout and stderrMichael J Gruber, Apr 22, 2010
  6. Michael J GruberMay 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.