git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision: --ancestry-path

From
Johan Herland <johan@herland.net>
Date
Apr 21, 2010, 07:34 UTC
Message-ID
<201004210934.30226.johan@herland.net>
In-Reply-To
<7v39ypg4gm.fsf_-_@alter.siamese.dyndns.org>
On Wednesday 21 April 2010, Junio C Hamano wrote:
> This is somewhat a rough-cut, as I haven't thought through possible
> interactions this new option may have with "rev-list --parents" and
> "rev-list --graph" (see "NEEDSWORK" in revision.c), but I'll leave that
> to people who are more interested in this topic than myself ;-).
Thanks! :)

I can confirm that this patch works with my original (more complicated) scenario. I've also played around with combinations of --ancestry-path, -- graph and --parents (and even --boundary), and AFAICS, the new option does not clobber the other options, and (IMHO) it all behaves correctly in the scenarios I've tested. Consider it:

Tested-by: Johan Herland <johan@herland.net>

I've also reviewed the patch, and it all looks good to me (i.e. "Acked-by", except I'm not super-familiar in the relevant area of the code).

What more should I do to push this forwards towards 'next'?
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Junio C HamanoNext: Johannes Sixt
Message 5 of 11 in “Getting 'git log' (or something else) to show me the relevant sub-graph?”
  1. Johan HerlandApr 20, 2010
  2. Michael J GruberApr 20, 2010
  3. Junio C HamanoApr 20, 2010
  4. revision: --ancestry-pathJunio C Hamano, Apr 20, 2010
  5. Johan HerlandApr 21, 2010
  6. Johannes SixtApr 21, 2010
  7. Junio C HamanoApr 21, 2010
  8. revision: --ancestry-pathJunio C Hamano, Apr 21, 2010
  9. Johan HerlandApr 21, 2010
  10. Junio C HamanoApr 21, 2010
  11. Junio C HamanoApr 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.