Re: [PATCH] git-gui: Fast staging/unstaging of hunks/lines

From: Johannes Sixt <j6t@kdbg.org>
Date: Apr 11, 2010, 19:01 UTC
Message-ID: <201004112101.54908.j6t@kdbg.org>
In-Reply-To: <x2o36ca99e91004110038oce1ffa15jc49244f228ce218@mail.gmail.com>

On Sonntag, 11. April 2010, Bert Wesarg wrote:

> On Mon, Apr 5, 2010 at 11:01, Bert Wesarg <bert.wesarg@googlemail.com>

wrote:

Show 6 quoted lines

> > This adds a shortcut to stage/unstage hunks or a range of lines. Which is
> > done on a mouse button 1 release event and holding the control key in the
> > diff view. If there is currently a selection only the selected lines will
> > be staged/unstaged. Otherwise the hunk will be staged/unstaged.
>
> Ping.

I gave the patch a quick try.

I don't think that I would use it a lot because it is very easy to mess up a staged change: The problem is that a click without anything selected will stage an entire hunk. I frequently use "Stage Line(s)" to separate neighboring changes that must go to separate commits, but with you feature it is very easy to forget to select something and, hence, to stage the entire hunk accidentally - which means that I would have to start over with the hunk and all the "quick" aspects of the feature would be lost.

That said, since I don't have Ctrl pressed very often while working in git-gui, the patch wouldn't hurt me, I think.

-- Hannes