Re: [PATCH 0/5] "status --ignored"

From: Jeff King <peff@peff.net>
Date: Apr 10, 2010, 08:40 UTC
Message-ID: <20100410084007.GA16843@coredump.intra.peff.net>
In-Reply-To: <7vd3y7ycgu.fsf@alter.siamese.dyndns.org>

On Sat, Apr 10, 2010 at 12:48:49AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > +	dir.flags |= DIR_COLLECT_IGNORED;
> 
> I thought about using collect-ignored so that fill_directory() does not
> have to be run twice, but IIRC it can short-circuit an entire directory
> using the "simplify" logic (as it was designed to be used for "git add"),
> no?

Hmm. I didn't consider that. It may be sufficient to say "foo/ is ignored" and let callers decide for themselves that "foo/bar" is ignored, too (unless, of course, it appears as tracked earlier in the list).

I just worry that your version will perform less well. I'm not that worried about the double traversal (on any reasonable system everything will be cached after the first traversal). But finding every file means we have to traverse areas that git otherwise wouldn't look at, which might mean going to disk to pull in all of the "foo/" directory structure (which is less likely to be cached, since the rest of git isn't touching it), even though it may not even be of interest to us.

-Peff