Re: [PATCH v4] gitk: Use git-difftool for external diffs
- From
David Aguilar <davvid@gmail.com>
- Date
- Apr 8, 2010, 09:02 UTC
- Message-ID
- <20100408090211.GA31594@gmail.com>
- In-Reply-To
- <201004021332.53562.markus.heidelberg@web.de>
On Fri, Apr 02, 2010 at 12:32:53PM +0100, Markus Heidelberg wrote:
Show 8 quoted lines
> David Aguilar, 2010-03-31 04:09: > > This teaches gitk about git-difftool. A benefit of this change > > is that gitk's external diff feature now works with read-only > > repositories. > > > > Signed-off-by: David Aguilar <davvid@gmail.com> > > Tested-by: Markus Heidelberg <markus.heidelberg@web.de>
Paul, you haven't replied yet but I do remember you mentioning that you like to keep gitk backwards-compat with older git. I have a newer version of this patch that checks for the existence of difftool --extcmd=<cmd> before trying to use it. It'll be PATCH v5.
-- David