[PATCH 0/6] Make the string_list API consistent
- From
Julian Phillips <julian@quantumfyre.co.uk>
- Date
- Apr 6, 2010, 01:11 UTC
- Message-ID
- <20100406011106.71279.92681.julian@quantumfyre.co.uk>
Currently most, but not all, string_list functions take the list as the first argument. This series changes the remaining functions to also take the string_list as the first argument which should make it easier to use the API.
The extensive use of string_lists does make this series both a bit large and a bit fragile for an API clean-up though. Perhaps making it more trouble than it's worth?
BTW: The basis for this series was the tip of pu at the time (f5e0e0a7), there didn't seem much point in trying to do it for master or next ...
Julian Phillips (6): string_list: Fix argument order for print_string_list string_list: Fix argument order for for_each_string_list string_list: Fix argument order for string_list_insert string_list: Fix argument order for string_list_insert_at_index string_list: Fix argument order for string_list_lookup string_list: Fix argument order for string_list_append
Documentation/technical/api-string-list.txt | 4 +- builtin/apply.c | 10 ++-- builtin/commit.c | 2 +- builtin/fast-export.c | 4 +- builtin/fetch.c | 18 ++++---- builtin/fmt-merge-msg.c | 18 ++++---- builtin/grep.c | 6 +- builtin/log.c | 20 ++++---- builtin/ls-files.c | 2 +- builtin/mailsplit.c | 2 +- builtin/mv.c | 2 +- builtin/remote.c | 68 +++++++++++++------------- builtin/rerere.c | 2 +- builtin/shortlog.c | 4 +- builtin/show-ref.c | 2 +- diff-no-index.c | 2 +- http-backend.c | 6 +- mailmap.c | 8 ++-- merge-recursive.c | 24 +++++----- notes.c | 12 ++-- reflog-walk.c | 4 +- remote.c | 6 +- rerere.c | 10 ++-- resolve-undo.c | 8 ++-- revision.c | 4 +- string-list.c | 18 ++++---- string-list.h | 16 +++--- transport-helper.c | 4 +- wt-status.c | 8 ++-- 29 files changed, 147 insertions(+), 147 deletions(-)