Re: [PATCHv5 5/6] gitweb: add documentation to INSTALL regarding gitweb.js

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 1, 2010, 11:46 UTC
Message-ID: <201004011346.54530.jnareb@gmail.com>
In-Reply-To: <4BB430FD.3050306@mailservices.uwaterloo.ca>

On Thu, 1 Apr 2010, Mark Rada wrote:

> This patch updates gitweb/INSTALL to mention gitweb.js, including
> JavaScript minification support.
> 
> Signed-off-by: Mark Rada <marada@uwaterloo.ca>

Thanks for this writeup.

For what it is worth:
Acked-by: Jakub Narebski <jnareb@gmail.com>

Show 5 quoted lines

> ---
> 
> Changes since v4:
> 	- Compacted the point about minification into CSS
> 	  point about minification

Nice to have differences from previous version described in comments...

> 
>  gitweb/INSTALL |   23 +++++++++++++----------
>  1 files changed, 13 insertions(+), 10 deletions(-)

This change migh have been a bit smaller without accompanying
rewrapping of affected paragraphs, but on the other hand it would
leave gitweb/INSTALL less readable.

Show 5 quoted lines

> @@ -79,13 +81,14 @@ Build example
>    we want to display are under /home/local/scm, you can do
>  
>  	make GITWEB_PROJECTROOT="/home/local/scm" \
> +             GITWEB_JS="/gitweb/gitweb.js" \

Minor nit: other lines use TAB + 5 x SPACE, so it should read:

  +	     GITWEB_JS="/gitweb/gitweb.js" \

   -----^^^^^

Show 5 quoted lines

>  	     GITWEB_CSS="/gitweb/gitweb.css" \
>  	     GITWEB_LOGO="/gitweb/git-logo.png" \
>  	     GITWEB_FAVICON="/gitweb/git-favicon.png" \
>  	     bindir=/usr/local/bin \
>  	     gitweb/gitweb.cgi

-- 
Jakub Narebski
Poland