Re: GIT_ONE_FILESYSTEM inclusion?

From: David Aguilar <davvid@gmail.com>
Date: Mar 27, 2010, 22:27 UTC
Message-ID: <20100327222730.GA10922@gmail.com>
In-Reply-To: <vpqd3yt4yyp.fsf@bauges.imag.fr>

On Wed, Mar 24, 2010 at 02:43:26PM +0100, Matthieu Moy wrote:

Show 22 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > On Wed, Mar 24, 2010 at 10:35, Johannes Sixt <j.sixt@viscovery.net> wrote:
> >> Am 3/24/2010 10:29, schrieb Alex Riesen:
> >>> And while at it, how about making it a config option? (i.e. core.oneFilesystem?)
> >>
> >> It's difficult to have this as a config option when you are looking for a
> >> repository... ;)
> >>
> >
> > Isn't it a little pointless to look for repository when you can't
> > access its config?
> 
> I guess Johannes's point is that the config option can be in
> $GIT_DIR/config, which you can't access when looking for $GIT_DIR.
> OTOH, looking at ~/.gitconfig to find a core.oneFilesystem makes sense
> (but is probably painfull to implement since the current code to parse
> config file will look for $GIT_DIR first).
> 
> -- 
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/

Right.

As this thread showed, we can't have a config option for this feature. Were there any other objections to the patch? It looks good to me.

Peff also agreed that it was an overall improvement. http://thread.gmane.org/gmane.comp.version-control.git/142262

Thread with the latest (v3) version of the patch: http://thread.gmane.org/gmane.comp.version-control.git/142436

We could use this feature at Disney Animation as well. We maintain a list of $GIT_CEILING_DIRECTORIES and could do without having to maintain it if we had this feature.

Plus, Lars is one of the git users that doesn't even flinch when the Perforce servers at Pixar get a hiccup, so we should try and help our fellow "renegade" git users ;-)

-- 
		David