Re: [PATCH v2] pull: mention "pull", not "fetch" in the error message.
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Mar 26, 2010, 23:12 UTC
- Message-ID
- <20100326231209.GB6797@blimp.localdomain>
- In-Reply-To
- <1269615836-13995-1-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy, Fri, Mar 26, 2010 16:03:56 +0100:
> For newbies who've just been taught "git pull", the error message > "Where do you want to fetch from today?" is indeed confusing. Change it > to "Where do you want to pull from today?" in case fetch was called from > pull.
...
Show 5 quoted lines
> @@ -842,8 +842,12 @@ static int fetch_one(struct remote *remote, int argc, const char **argv)
> int ref_nr = 0;
> int exit_code;
>
> + char *cmd = getenv("GIT_USER_COMMAND");Isn't the variable name a little too generic? USER_COMMAND doesn't make it clear that its only purpose is to pass a string "pull" to an error message which is never even seen under normal circumstances.