git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Cherry-pick with symlinks fails horribly

From
Christian Couder <chriscool@tuxfamily.org>
Date
Mar 25, 2010, 05:01 UTC
Message-ID
<201003250601.44871.chriscool@tuxfamily.org>
In-Reply-To
<7vljdyt7h8.fsf@alter.siamese.dyndns.org>
On Friday 12 March 2010 06:49:23 Junio C Hamano wrote:
Show 20 quoted lines
> Christian Couder <chriscool@tuxfamily.org> writes:
> > Anyway when looking at t/t6035-merge-dir-to-symlink.sh, we can see that
> > there are still 2 broken tests:
> >
> > $ ./t6035-merge-dir-to-symlink.sh
> > ...
> > *   ok 5: do not lose a/b-2/c/d in merge (resolve)
> > *   still broken 6: do not lose a/b-2/c/d in merge (recursive)
> > *   ok 7: setup a merge where dir a/b-2 changed to symlink
> > *   ok 8: merge should not have conflicts (resolve)
> > *   still broken 9: merge should not have conflicts (recursive)
> > * still have 2 known breakage(s)
> > * passed all remaining 7 test(s)
> >
> > So it looks like breakages in this area are known, though perhaps not
> > your particular breakage.
> 
> The above shows that resolve passes the same tests that recursive fails,
> which means that the breakage is likely to be in recursive, and not in
> unpack-trees, as you seemt to have guessed earlier.  
Yes, you are right the breakage is in recursive as it works with resolve.
Show 9 quoted lines
> If cherry-pick were
> still a shell script, we could easily test that conjecture by letting you
> try running it using resolve instead of recursive, but things like that
> has got a lot harder to do these days since many things were rewritten in
> C (sigh).
> 
> It might not be a bad idea to teach a hidden primarily-for-debugging
> option to "cherry-pick" to let it use resolve instead of recursive for
> cases like this.

I will send an RFC patch series to do that. I used it to check that the test case works with the resolve strategy.

Best regards, Christian.

Previous: Junio C Hamano
Message 7 of 7 in “Cherry-pick with symlinks fails horribly”
  1. Alexander GladyshMar 9, 2010
  2. Alexander GladyshMar 10, 2010
  3. Christian CouderMar 11, 2010
  4. Alexander GladyshMar 11, 2010
  5. Christian CouderMar 12, 2010
  6. Junio C HamanoMar 12, 2010
  7. Christian CouderMar 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.