Re: "git add -i" with path gives "Argument list too long"

From: Jeff King <peff@peff.net>
Date: Mar 22, 2010, 01:41 UTC
Message-ID: <20100322014100.GA7717@coredump.intra.peff.net>
In-Reply-To: <7vwrx56tet.fsf@alter.siamese.dyndns.org>

On Sun, Mar 21, 2010 at 06:23:38PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > their behavior. Junio could probably say more, or you will have to read
> > the code.
> 
> Or read what I already said here a few times ;-) I generally do not want
> to repeat myself.

Well, yeah. :) What I meant was:

Show 9 quoted lines

> There are two semantics of pathspecs:
> 
>   (1) exact match, or leading path.  e.g.
> 
>   	git ls-files Makefile Documentation/
> 
>   (2) exact match, leading path, or fnmatch(3).
> 
> 	git ls-files Makefile Documentation/ '*.txt'

Is type (2) exactly fnmatch? Or are there subtle corner cases that should be tested? For the implementation it shouldn't matter, as hopefully the same code paths will be used, and "just like ls-files" should be specification enough. But for testing, it might be nice to enumerate some of the more subtle cases.

-Peff