Re: [PATCH] Add a git-completion rpm subpackage to the spec

From: Todd Zullinger <tmz@pobox.com>
Date: Mar 21, 2010, 15:51 UTC
Message-ID: <20100321155156.GH27676@inocybe.localdomain>
In-Reply-To: <1269119663-sup-5823@pinkfloyd.chass.utoronto.ca>

Ben Walton wrote:

Show 12 quoted lines

> Excerpts from Junio C Hamano's message of Sat Mar 20 16:12:34 -0400
> 2010:
>
>> looks sensible.  May I ask for what distribution you are "handling
>> it"?  The last thing I want to do is to get in the way of distro
>> packagers.
>
> I can't say it's _the_ global definition for RPM based distros, but
> I suspect the redhat derived ones would use this location.  I'm
> working against RHEL5.
>
> The info that Ian provides seems to corroborate this hypothesis.

FWIW, upstream bash-completion is no longer handled by Ian. The current upstream is at http://bash-completion.alioth.debian.org/

The paths haven't changed currently, though I thought I read that eventually they'd like to move the default location for completion scripts to /usr/share/bash-completion/ (many are already installed there, but are symlinked to /etc/bash_completion.d by bash-completion packages (in the Fedora/EPEL packages via %triggers when the applications they complete are installed).

Also worth noting for RHEL/CentOS 5 folks is that the current Fedora packages should rebuild cleanly on those systems. Typically, I do this via mock, which sets some of the needed rpm macros, but they are also available in the buildsys-macros package¹. I'm hoping to move git in EPEL to a newer version at some point but I haven't made time to do so yet.

I also haven't made time to see what, if any, of the changes we've made in the Fedora packages might be worthwhile to integrate into the git.git rpm spec file. :/

The Fedora packages install the completion scripts by default. The completion is only sourced when someone has installed bash-completion, so the thought is that if you installed that you would want git to provide completion by default. For those that only want git completion without the more general bash-completion package, it's simple to source /etc/bash_completion.d/git. In that light, is there a compelling reason not to install the completion by default?

¹ http://buildsys.fedoraproject.org/buildgroups/rhel5/i386/
  The may eventually be added to the epel-release package to make it
  simpler to rebuild EPEL packages (and Fedora packages on EPEL).

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
People are crazy and times are strange
I'm locked in tight, I'm out of range
I used to care, but things have changed