Re: [egit-dev] Translation of reflog messages?

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Mar 19, 2010, 09:42 UTC
Message-ID: <201003191042.01536.robin.rosenberg@dewire.com>
In-Reply-To: <20100319040420.GA14689@spearce.org>

fredagen den 19 mars 2010 05.04.20 skrev  Shawn O. Pearce:

Show 16 quoted lines

> "Lay, Stefan" <stefan.lay@sap.com> wrote:
> > Do we need to externalize reflog messages?
> >
> > We proposed a change to externalize all translatable Strings in egit.core
> > (http://egit.eclipse.org/r/#change,332). It contains code that writes to
> > the reflog, for example in BranchOperation:
> >
> > RefUpdate u = repository.updateRef(Constants.HEAD);
> > u.setRefLogMessage("checkout: moving to " + refName, false);
> >
> > Is this message subject to translation? Or maybe only part of it, namely
> > the name of the git command "checkout"? Are there tools which parse the
> > reflog message and rely on standardized texts?
> 
> Nope.  Currently nobody relies on the format of the message part of a
> reflog record.  So translating them should not break an application.

Show 6 quoted lines

> Since these are strictly local to the repository, it probably makes
> sense to translate these messages for the user, so they make sense
> to them when they are reading a reflog history in some sort of
> browser UI.
> 
> I say, translate them.

On the other hand we try to use the same format as C git, which doesn't translate. Keeping the current messages and trying to translate on read is another option. Be careful to translate only those parts that can be positively identified, so some pattern matching is required.

If the contents of the reflog is translated before putting it there we destroy all ability for people to make ad-hoc use of it using . I occasionally grep the log and a mix of swedish and english makes that much harder.

(Cc:ing the Git ML)

-- robin