Re: FEATURE REQUEST: sendemail.aliasesfile support enavironment variables and tilde

From: Jeff King <peff@peff.net>
Date: Mar 13, 2010, 07:40 UTC
Message-ID: <20100313074031.GA5467@sigill.intra.peff.net>
In-Reply-To: <87zl2dtl5g.fsf@jondo.cante.net>

On Fri, Mar 12, 2010 at 09:06:19PM +0200, Jari Aalto wrote:

Show 12 quoted lines

> It apperas that this is not possible with 1.7.0:
> 
>     # ~/.gitconfig
>     [sendemail]
>             aliasesfile = $HOME/.mailrc
> 
> => opening $HOME/.mailrc: No such file or directory
> ls -la $HOME/.mailrc
> lrwxrwxrwx 1 root root 35 2008-05-31 11:08 /home/foo/.mailrc -> vc/git/shell-account-common/.mailrc
> 
> Neither seems to be "~/.mailrc" accpeted. Please add support for at
> least tilde(~).

If you (or anyone) are interested in writing the patch, it is as simple as adding "--path" to the "git config" call for sendemail.aliasesfile. Which unfortunately is not that simple, due to the way that sendemail handles its config values, but the refactoring should not be too hard.

-Peff