Re: [PATCH] Do not strip empty lines / trailing spaces from a commit message template

From: Jeff King <peff@peff.net>
Date: Mar 11, 2010, 22:46 UTC
Message-ID: <20100311224656.GA25553@sigill.intra.peff.net>
In-Reply-To: <7vaaueziv8.fsf@alter.siamese.dyndns.org>

On Thu, Mar 11, 2010 at 12:46:51PM -0800, Junio C Hamano wrote:

> > How about a test to check the new behavior?
> 
> Speaking of tests, t2203 will segfault with your patch.  I don't think the
> following does, though.

I thought I ran the tests, but obviously not. I see the segfault here. It is not just t2203, but any "git commit" with no message will cause it.

Your patch looks right, and is more readable, too, I think.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.