Re: wishlist: git gui not listing untracked files in unstaged list

From: Jeff King <peff@peff.net>
Date: Mar 11, 2010, 07:11 UTC
Message-ID: <20100311071145.GA5919@sigill.intra.peff.net>
In-Reply-To: <4B9896D4.2020106@viscovery.net>

On Thu, Mar 11, 2010 at 08:08:04AM +0100, Johannes Sixt wrote:

Show 13 quoted lines

> > It depends on the shell. Bash will expand it in _some_ cases (but not
> > this one). Dash never will:
> > 
> >   $ echo $BASH_VERSION
> >   4.1.0(1)-release
> >   $ echo foo=~/foo ;# expands
> >   foo=/home/peff/foo
> 
> This is wrong, FWIW. Tilde expansion must happen only at the beginning of
> a word or, when in an assignment, at the beginning of the assigned value
> or after any unquoted ':'. Note that in `echo foo=~/foo`, what looks like
> an assignment is *not* an assignment in POSIX shell lingo because it comes
> after the command name.

Thanks for the reference. I thought it was a bit funny when I wrote the above, but just assumed it was implementation defined.

I think it doesn't change our outcome, though. Even though we cannot rely on the shell to do such an expansion, it is still probably not sane to assume ls-files will do it. Git's expansion is connected with the config entry, not the use in ls-files, and it is git-gui's responsibility to correctly expand as it reads the config.

-Peff