Re: core.autocrlf considered half-assed

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Mar 7, 2010, 09:27 UTC
Message-ID: <20100307092701.GC31105@dpotapov.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.1003060018170.20986@pacific.mpi-cbg.de>

On Sat, Mar 06, 2010 at 12:23:33AM +0100, Johannes Schindelin wrote:

Show 5 quoted lines

> 
> back then, I was not a fan of the core.autocrlf support. But I have to 
> admit that in the meantime, I turned into an outright un-fan of the 
> feature. Not because its intent is wrong, but because its implementation 
> is lousy.

Well, I agree there are some issues with it. In particularly, when someone changes core.autocrlf in his/her repository, and then git behavior is outright confusing. IMHO, the nuts of the problem is that does not store in the index how files were checkout. Instead it uses core.autocrlf, which specifies how the user _wants_ files to be check- out. So, when the autocrlf option changes, things get very confusing. However:

> Just try to "git reset --hard" or "git stash" when there are files with 
> DOS line endings and when core.autocrlf is not false.

I did, and I have not noticed any problem with that.

git init git config core.autocrlf true echo foo^ | tr ^ '\r' > foo git add foo git commit -m 'add foo' echo more^ | tr ^ '\r' >> foo echo "Before reset:" tr '\r' ^ < foo git reset --hard echo "After reset:" git diff tr '\r' ^ < foo

Dmitry