git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] gitk: Add comments to explain encode_view_opts and decode_view_opts

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 6, 2010, 22:48 UTC
Message-ID
<20100306224837.GB7064@progeny.tock>
In-Reply-To
<20100306224605.GA7064@progeny.tock>
Summarize these functions to save the reader some time.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 gitk |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 1f36a3e..7f498b5 100755
--- a/gitk
+++ b/gitk
@@ -3845,6 +3845,7 @@ set known_view_options {
     {cmd       t50= +  {}               {mc "Command to generate more commits to include:"}}
     }
 
+# Convert $newviewopts($n, ...) into args for git log.
 proc encode_view_opts {n} {
     global known_view_options newviewopts
 
@@ -3878,6 +3879,7 @@ proc encode_view_opts {n} {
     return [concat $rargs [shellsplit $newviewopts($n,args)]]
 }
 
+# Fill $newviewopts($n, ...) based on args for git log.
 proc decode_view_opts {n view_args} {
     global known_view_options newviewopts
 
-- 
1.7.0
Previous: Jonathan NiederNext: Jonathan Nieder
Message 2 of 3 in “stop clobbering "Remember This View" setting”
  1. 0/2 stop clobbering "Remember This View" settingJonathan Nieder, Mar 6, 2010
  2. 1/2 gitk: Add comments to explain encode_view_opts and decode_view_optsJonathan Nieder, Mar 6, 2010
  3. 2/2 gitk: Stop clobbering "Remember This View" settingJonathan Nieder, Mar 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.