git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 9/9] rebase -i: use new --ff cherry-pick option

From
Christian Couder <chriscool@tuxfamily.org>
Date
Mar 3, 2010, 20:11 UTC
Message-ID
<20100303201146.23506.89089.chriscool@tuxfamily.org>
In-Reply-To
<20100303201046.23506.32653.chriscool@tuxfamily.org>
This simplifies rebase -i a little bit.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-rebase--interactive.sh |   15 +++------------
 1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 415ae72..a57f043 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -230,8 +230,8 @@ do_with_author () {
 }
 
 pick_one () {
-	no_ff=
-	case "$1" in -n) sha1=$2; no_ff=t ;; *) sha1=$1 ;; esac
+	ff=--ff
+	case "$1" in -n) sha1=$2; ff= ;; *) sha1=$1 ;; esac
 	output git rev-parse --verify $sha1 || die "Invalid commit name: $sha1"
 	test -d "$REWRITTEN" &&
 		pick_one_preserving_merges "$@" && return
@@ -240,16 +240,7 @@ pick_one () {
 		output git cherry-pick "$@"
 		return
 	fi
-	parent_sha1=$(git rev-parse --verify $sha1^) ||
-		die "Could not get the parent of $sha1"
-	current_sha1=$(git rev-parse --verify HEAD)
-	if test -z "$no_ff" && test "$current_sha1" = "$parent_sha1"
-	then
-		output git reset --hard $sha1
-		output warn Fast-forward to $(git rev-parse --short $sha1)
-	else
-		output git cherry-pick "$@"
-	fi
+	output git cherry-pick $ff "$@"
 }
 
 pick_one_preserving_merges () {
-- 
1.7.0.315.gbc198
Previous: Christian Couder
Message 10 of 10 in “add --ff option to cherry-pick”
  1. 0/9 add --ff option to cherry-pickChristian Couder, Mar 3, 2010
  2. 1/9 reset: refactor updating heads into a static functionChristian Couder, Mar 3, 2010
  3. 2/9 reset: refactor reseting in its own functionChristian Couder, Mar 3, 2010
  4. 3/9 reset: make reset function non static and declare it in "reset.h"Christian Couder, Mar 3, 2010
  5. 4/9 revert: refactor checking parent in a check_parent() functionChristian Couder, Mar 3, 2010
  6. 5/9 revert: add --ff option to allow fast forward when cherry-pickingChristian Couder, Mar 3, 2010
  7. 6/9 cherry-pick: add tests for new --ff optionChristian Couder, Mar 3, 2010
  8. 7/9 Documentation: describe new cherry-pick --ff optionChristian Couder, Mar 3, 2010
  9. 8/9 cherry-pick: add a no-op --no-ff option to future proof scriptsChristian Couder, Mar 3, 2010
  10. 9/9 rebase -i: use new --ff cherry-pick optionChristian Couder, Mar 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.