Re: [PATCH 2/3] Different views on a repository

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 24, 2010, 17:42 UTC
Message-ID: <20100224174235.GA20567@spearce.org>
In-Reply-To: <92fea2335b73265b04d64fcc217055e1170f5e16.1267029680.git.agruen@suse.de>

Andreas Gruenbacher <agruen@suse.de> wrote:

> Add --view options in upload-pack and receive-pack so that a repository
> on the server side can be made to look like several independent
> repositories on the client side.

Before saying this is good... I'd like to know how a repository owner is supposed to set these options on the user started invocations of other remote side program.

Right now, I don't see how this is too different from just doing the following on a client:

  git init
  git remote add origin URL
  git config remote.origin.fetch refs/heads/one/*:refs/remotes/origin/*

and therefore shouldn't just be handled on the *client* side of the connection, as part of the remote setup and push matching refs rules.

(Of course, the push matching ref logic is messy too... adding yet more into that pile might also be ugly.)

> +const char *view_to_ref(const char *refname, const char *view)
> +{
> +	static char *buffer;

...

> +	buffer = xrealloc(buffer, prefix_len + view_len + suffix_len + 1);
> +	sprintf(buffer, "%.*s%s%s", prefix_len, refname, view, suffix);
> +	return buffer;

I'd rather not use a static buffer like this. Why not alloc and let the caller free? Or have the caller pass in a strbuf you populate for them?

-- 
Shawn.