Re: git-push segfault

From: Jeff King <peff@peff.net>
Date: Feb 24, 2010, 09:23 UTC
Message-ID: <20100224092356.GA28959@coredump.intra.peff.net>
In-Reply-To: <20100224082214.GA31559@inner.home.ulmdo.de>

On Wed, Feb 24, 2010 at 09:22:14AM +0100, Andreas Krey wrote:

Show 8 quoted lines

> On Wed, 24 Feb 2010 01:36:06 +0000, Jeff King wrote:
> ...
> > #!/bin/sh
> ...
> > git clone parent child &&
> > cd child &&
> 
> How about 'set -xe' instead of all the &&?

I long ago stopped trying to remember all of the places where "-e" works and where it doesn't, and just use explicit "&&" (or "|| exit 1"). For example, the subshell in my recipe needs an explicit error check under dash, but will exit correctly using bash. I seem to recall there are some other gotchas, but it has been a long time since I looked.

At any rate, this is not even code for inclusion in git. It is "please cut and paste this and tell me if it breaks". So I am not too worried about style.

-Peff