Re: [PATCH v5 02/11] Support showing notes from more than one notes tree

From: Thomas Rast <trast@student.ethz.ch>
Date: Feb 23, 2010, 17:10 UTC
Message-ID: <201002231810.18960.trast@student.ethz.ch>
In-Reply-To: <7vsk8sn2o3.fsf@alter.siamese.dyndns.org>

On Tuesday 23 February 2010 02:47:40 Junio C Hamano wrote:

Show 6 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
> > * remove NOTES_SHOW_HEADER_WITH_REF distinction
> 
> Note that there is a leftover caller that uses the symbol without noticing
> that it has been retired.  I'll fix it up locally when I queue the series
> to 'pu'.

Thanks. That was the breakage I hinted at in the last mail last night; since it (hopefully) was the only problem with the series, I'll dispense with the replacement for now.

Show 10 quoted lines

> > @@ -68,6 +70,9 @@ struct non_note {
> >  
> >  struct notes_tree default_notes_tree;
> >  
> > +struct string_list display_notes_refs;
> > +struct notes_tree **display_notes_trees;
> 
> Unlike default_notes_tree, the above two can become static, as you made
> the new logic better contained to this file and accessible only via
> accessor functions.

Oh, so that's what you hinted at with the 'extern' question...

> As you are retiring format_note() as a public interface, and instead
> making format_display_notes() as the primary API for the callers, the

I still need it for the "format-patch from notes" patch, to be posted soonish. So unless someone comes up with an alternative for that, it stays a public interface.

> former should be made static to notes.c along with the large comment
> describing how to call it.  It may also be worth telling people how to
> call this new public interface with similar comment here.

You caught me on my comment laziness... I suspect even the ones I can add won't match Johan's excellent comments :-)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch