git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] am: remove rebase-apply directory before gc

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Feb 22, 2010, 14:35 UTC
Message-ID
<20100222143545.GA4791@progeny.tock>
In-Reply-To
<20100222140911.30949.49607.reportbug@rakim.wolfsonmicro.main>

When git am does an automatic gc it doesn't clean up the rebase-apply directory until after this has finished. This means that if the user aborts the gc then future am or rebase operations will report that an existing operation is in progress, which is undesirable and confusing.

Reported by Mark Brown <broonie@debian.org> through http://bugs.debian.org/570966

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 git-am.sh |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index 3c08d53..ebfbee5 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -776,6 +776,5 @@ do
 	go_next
 done
 
-git gc --auto
-
 rm -fr "$dotest"
+git gc --auto
-- 
1.7.0
Message 1 of 1 in “am: remove rebase-apply directory before gc”
  1. am: remove rebase-apply directory before gcJonathan Nieder, Feb 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.