git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 00/11] several notes refs, post-rewrite, notes rewriting

From
Thomas Rast <trast@student.ethz.ch>
Date
Feb 22, 2010, 00:32 UTC
Message-ID
<201002220132.53455.trast@student.ethz.ch>
In-Reply-To
<7vr5oeazhd.fsf@alter.siamese.dyndns.org>
On Monday 22 February 2010 01:25:02 Junio C Hamano wrote:
Show 9 quoted lines
> Thomas Rast <trast@student.ethz.ch> writes:
> 
> > core.notesRef should be in that list
> > implicitly, and I think the natural position if it is unsorted would
> > be: first.
> 
> I think that is a sane thing to do, and then any additional ones can come
> after that first one, in the order specified by displayRef.  Isn't that
> what you are doing, no?

Yes, I just wanted to spell out why I originally decided for the sorted instead of user-ordered way:

> > However, that means that changing core.notesRef or GIT_NOTES_REF
> > can shuffle around your notes, which I thought would be confusing.

But that wasn't a strong preference at all, so doing it like you suggested (and like the code is in v4) is fine by me.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Junio C Hamano
Message 17 of 17 in “several notes refs, post-rewrite, notes rewriting”
  1. 00/11 several notes refs, post-rewrite, notes rewritingThomas Rast, Feb 22, 2010
  2. 01/11 test-lib: unset GIT_NOTES_REF to stop it from influencing testsThomas Rast, Feb 22, 2010
  3. 02/11 Support showing notes from more than one notes treeThomas Rast, Feb 22, 2010
  4. Junio C HamanoFeb 22, 2010
  5. Thomas RastFeb 22, 2010
  6. Junio C HamanoFeb 23, 2010
  7. 03/11 Documentation: document post-rewrite hookThomas Rast, Feb 22, 2010
  8. 04/11 commit --amend: invoke post-rewrite hookThomas Rast, Feb 22, 2010
  9. 05/11 rebase: invoke post-rewrite hookThomas Rast, Feb 22, 2010
  10. 06/11 rebase -i: invoke post-rewrite hookThomas Rast, Feb 22, 2010
  11. 07/11 notes: implement 'git notes copy --stdin'Thomas Rast, Feb 22, 2010
  12. 08/11 notes: implement helpers needed for note copying during rewriteThomas Rast, Feb 22, 2010
  13. 09/11 rebase: support automatic notes copyingThomas Rast, Feb 22, 2010
  14. 10/11 commit --amend: copy notes to the new commitThomas Rast, Feb 22, 2010
  15. 11/11 notes: add shorthand --ref to override GIT_NOTES_REFThomas Rast, Feb 22, 2010
  16. Junio C HamanoFeb 22, 2010
  17. Thomas RastFeb 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.