Re: Storing (hidden) per-commit metadata

From: Jeff King <peff@peff.net>
Date: Feb 21, 2010, 08:52 UTC
Message-ID: <20100221085237.GA31189@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.1002210945490.20986@pacific.mpi-cbg.de>

On Sun, Feb 21, 2010 at 09:49:28AM +0100, Johannes Schindelin wrote:

Show 7 quoted lines

> > If the only problem is that the data is ugly in "git show", then perhaps 
> > we need a "suppress these pseudo-headers" feature for showing logs. It 
> > keeps them easily available for inspection or for --grep, but most of 
> > the time you would not see them.
> 
> Whoa. Even more processing to do for each commit during a "git log" run? 
> You know, other people are working on _accelerating_ git log as we speak!

I think this is premature. You would not need to pay the price for such a feature if you were not actually using it. On top of which, as it does not yet exist, it has not actually been benchmarked. So any complaints should wait until it is actually implemented.

Show 5 quoted lines

> And really, while I can understand that the OP wanted to hide the 
> information, I am really against that. For example, when I see a log with 
> git-svn footers, it gives me _additional_ information which I actually 
> like (it tells me where these commits really come from). If they do not 
> need bidirectional, they can skip those footers.

I think it depends on what the information is, which I'm still not clear on. But most importantly, I think it makes sense to put control of whether that information is seen in the hands of the user who is invoking git.

-Peff

PS I tried to keep this message short. Short enough? :)