Re: [PATCH] Add an optional argument for --color options
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Feb 14, 2010, 12:21 UTC
- Message-ID
- <20100214122118.GA3630@progeny.tock>
- In-Reply-To
- <20100214064408.GB20630@coredump.intra.peff.net>
Jeff King wrote:
> On Sat, Feb 13, 2010 at 05:01:15PM -0500, Mark Lodato wrote:
>> Make git-branch, git-show-branch, git-grep, and all the diff-based >> programs accept an optional argument <when> for --color.
[...]
> My only complaint in that respect is that there are no tests. However, > I'm not sure we can get a very satisfying test, since the test scripts > may or may not have stdout going to a tty.
See [1]. ;-)
Hope that helps, Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/139831/focus=139906