git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add -p: make the beginning of the hunk easier to see

From
Jeff King <peff@peff.net>
Date
Feb 13, 2010, 11:23 UTC
Message-ID
<20100213112342.GA1299@coredump.intra.peff.net>
In-Reply-To
<4B768807.3030003@gmail.com>
On Sat, Feb 13, 2010 at 12:07:51PM +0100, Björn Gustavsson wrote:
Show 13 quoted lines
> diff --git a/git-add--interactive.perl b/git-add--interactive.perl
> index cd43c34..4eb7c7c 100755
> --- a/git-add--interactive.perl
> +++ b/git-add--interactive.perl
> @@ -1439,6 +1439,8 @@ sub patch_update_file {
>  					 !defined $hunk[$ix]{USE});
>  			}
>  		}
> +	} continue {
> +		print "\n" x 4, '=' x 72, "\n";
>  	}
>  
>  	@hunk = coalesce_overlapping_hunks(@hunk);

Wow, I find this terrifically ugly. I guess you don't use color.interactive, which will output a colored hunk header? Or is it that small hunks tend to confused with the previous hunk?

-Peff
Previous: Björn GustavssonNext: Jeff King
Message 2 of 10 in “add -p: make the beginning of the hunk easier to see”
  1. add -p: make the beginning of the hunk easier to seeBjörn Gustavsson, Feb 13, 2010
  2. Jeff KingFeb 13, 2010
  3. Jeff KingFeb 13, 2010
  4. Björn GustavssonFeb 13, 2010
  5. Björn GustavssonFeb 13, 2010
  6. Björn GustavssonFeb 13, 2010
  7. Jeff KingFeb 13, 2010
  8. Björn GustavssonFeb 13, 2010
  9. Julian PhillipsFeb 13, 2010
  10. Björn GustavssonFeb 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.