Re: [PATCH] git-gui: check whether systems nice command works or disable it

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 8, 2010, 15:56 UTC
Message-ID: <20100208155631.GB19288@spearce.org>
In-Reply-To: <7vhbps4lwr.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> > diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> > index 1fb3cbf..eec2dc9 100755
> > --- a/git-gui/git-gui.sh
> > +++ b/git-gui/git-gui.sh
> > @@ -388,6 +388,9 @@ proc _lappend_nice {cmd_var} {
> >  
> >  	if {![info exists _nice]} {
> >  		set _nice [_which nice]
> > +		if {[catch {exec $_nice git version}]} {
> > +			set _nice {}
> > +		}
> 
> Where does the output from this "git version" invocation go?

By default Tcl exec returns stdout's contents. So in this case, its passed to catch, which discards it, because catch returns true if exec crashed, false if it ran without error.

Patch looks fine to me as-is.

-- 
Shawn.