Re: upload-pack timing issue on windows?

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 6, 2010, 10:06 UTC
Message-ID: <201002061106.04305.j6t@kdbg.org>
In-Reply-To: <40aa078e1002051551o6d116a50uee3f6a32b16adb46@mail.gmail.com>

On Samstag, 6. Februar 2010, Erik Faye-Lund wrote:

Show 11 quoted lines

> As some of you might know, I've been working on porting git-daemon to
> Windows for quite some time now. As it stands now, there's really only
> one known issue that is blocking on my end here:
>
> Something weird happens *sometimes* when upload-pack is exiting,
> leading to a client dying with a "fatal: read error: Invalid
> argument\nfatal: early EOF"-error. If I place a sleep(1) at some place
> after exiting the while(1)-loop in create_pack() in upload-pack.c, the
> symptom goes away. create_pack() contains some async-code, but this
> doesn't seem to be triggered in my minimal case at all. I've tried
> flushing stdout and stderr explicitly, no luck.

I've observed timing related issues in upload-pack as well, but only in the case where the die() is called from the async thread. This is the reason why t5530 does not pass.

But your case seems to be different - i.e. there is no die() involved. Sorry, can't help more...

Perhaps use Procmon to analyse differences among the different successful and failing cases.

Try hacking fetch-pack so that it does not announce side-band(-64k). Perhaps it makes a difference.

-- Hannes