Re: [PATCH 2/3] silence human readable info messages going to stderr from git push --porcelain

From: Larry D'Anna <larry@elder-gods.org>
Date: Feb 5, 2010, 20:30 UTC
Message-ID: <20100205203045.GA1937@cthulhu>
In-Reply-To: <7v1vgz5ta7.fsf@alter.siamese.dyndns.org>

* Junio C Hamano (gitster@pobox.com) [100205 15:20]:

Show 7 quoted lines

> > -		if (!quiet && !ret && !refs_pushed(remote_refs))
> > +		if (!quiet && !porcelain && !ret && !refs_pushed(remote_refs))
> >  			fprintf(stderr, "Everything up-to-date\n");
> 
> This is a borderline.  If you are truly up-to-date, the calling script
> won't get anything.  It may be easier for Porcelain scripts to see this
> message on the standard output as an explicit succeses report instead.

how about this?

if (!quiet && (!porcelain || verbose) && !ret && !refs_pushed(remote_refs))
   fprintf(stderr, "Everything up-to-date\n");

   --larry