git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fast-import: Stream very large blobs directly to pack

From
Shawn O. Pearce <spearce@spearce.org>
Date
Feb 4, 2010, 02:30 UTC
Message-ID
<20100204023056.GQ14799@spearce.org>
In-Reply-To
<7vk4utybur.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> And this is a fix-up for the mismerge.  I didn't touch max-pack-size stuff.
> 
>  fast-import.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/fast-import.c b/fast-import.c
> index ca21082..a6730d0 100644
> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -2800,7 +2800,10 @@ static int parse_one_option(const char *option)
>  	if (!prefixcmp(option, "max-pack-size=")) {
>  		option_max_pack_size(option + 14);
>  	} else if (!prefixcmp(option, "big-file-threshold=")) {
> -		big_file_threshold = strtoumax(option + 19, NULL, 0) * 1024 * 1024;
> +		unsigned long v;
> +		if (!git_parse_ulong(option + 19, &v))
> +			return 0;
> +		big_file_threshold = v;
Yup, looks good to me.
-- 
Shawn.
Previous: Junio C HamanoNext: Nicolas Pitre
Message 24 of 27 in “fast-import: Stream very large blobs directly to pack”
  1. fast-import: Stream very large blobs directly to packShawn O. Pearce, Jan 29, 2010
  2. Nicolas PitreJan 29, 2010
  3. Shawn O. PearceJan 29, 2010
  4. Junio C HamanoJan 29, 2010
  5. Shawn O. PearceJan 29, 2010
  6. fast-import: Stream very large blobs directly to packShawn O. Pearce, Jan 29, 2010
  7. Jakub NarebskiJan 29, 2010
  8. Shawn O. PearceJan 29, 2010
  9. A Large Angry SCMJan 29, 2010
  10. Junio C HamanoJan 30, 2010
  11. Sverre RabbelierJan 29, 2010
  12. Shawn O. PearceJan 29, 2010
  13. Sverre RabbelierJan 29, 2010
  14. Shawn O. PearceJan 29, 2010
  15. Junio C HamanoJan 30, 2010
  16. Junio C HamanoJan 30, 2010
  17. Junio C HamanoJan 30, 2010
  18. Shawn O. PearceFeb 1, 2010
  19. Junio C HamanoFeb 1, 2010
  20. Junio C HamanoFeb 4, 2010
  21. Shawn O. PearceFeb 4, 2010
  22. Junio C HamanoFeb 4, 2010
  23. Junio C HamanoFeb 4, 2010
  24. Shawn O. PearceFeb 4, 2010
  25. Nicolas PitreFeb 4, 2010
  26. fast-import: Document the core.bigFileThreshold configuration settingShawn O. Pearce, Feb 1, 2010
  27. Shawn O. PearceFeb 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.