Re: [gitolite] repo config for delegated projects

From: Teemu Matilainen <teemu.matilainen@iki.fi>
Date: Feb 3, 2010, 22:47 UTC
Message-ID: <20100203224734.GI4808@reaktor.fi>
In-Reply-To: <20100203202249.GA27125@lapse.rw.madduck.net>

On Thu, 04 Feb 2010, martin f krafft wrote:

Show 11 quoted lines

> src/gl-compile-conf:261 prohibits delegated repositories to make use
> of the functionality to configure config variables of the
> repositories:
> 
>   die "$WARN $fragment attempting to set repo configuration\n"
>     if $fragment ne 'master';
> 
> This is a bit unfortunate and makes me reconsider the use of
> delegations.
> 
> What is the reason for this restriction?

Well, the main reason probably is that I don't personally use delegation and got tired of even thinking about the security concerns. =)

> Are there settings that are potentially compromising?

I think it depends on the setup and especially hooks. Can't come up with any real problem, though.

> Would it be worth to consider making it configurable (e.g.
> ~/.gitolite.rc) whether to allow delegated repos to set config
> variables?

That's Sitaram's call. :)

-- 
	- Teemu