Re: [PATCH 0/2] upload-pack: pre- and post- hooks

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 1, 2010, 16:36 UTC
Message-ID: <20100201163618.GB9394@spearce.org>
In-Reply-To: <alpine.LFD.2.00.1002011116320.1681@xanadu.home>

Nicolas Pitre <nico@fluxnic.net> wrote:

Show 13 quoted lines

> On Mon, 1 Feb 2010, Shawn O. Pearce wrote:
> I think such hooks could be allowed only if triggered explicitly by the 
> upload-pack caller, such as git-daemon.  That's probably the only 
> scenario where a useful use case can be justified for them anyway.
> 
> And of course, to avoid any security problems, the actual hooks must not 
> be provided by the repository owner but provided externally, like from 
> git-daemon, via some upload-pack command line arguments.  This way the 
> hooks are really controlled by the system administrator managing 
> git-daemon and not by any random git repository owner.
> 
> That should be good enough for all the use cases those hooks were 
> originally designed for.

Oooh, I like that.

If the paths to the hooks are passed in on the command line of git-upload-pack, and git-daemon takes those options and passes them through, you're right, we probably get everything we need.

Gitosis can still use the hooks if it wants, since it controls the call of git-upload-pack.

-- 
Shawn.