Re: pack.packSizeLimit, safety checks
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Feb 1, 2010, 16:28 UTC
- Message-ID
- <20100201162816.GA9394@spearce.org>
- In-Reply-To
- <4B6700CF.1090106@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 10 quoted lines
> Nicolas Pitre schrieb: > > Grrrrr. This is a terrible discrepency given that all the other > > arguments in Git are always byte based, with the optional k/m/g suffix, > > by using git_parse_ulong(). So IMHO I'd just change --max-pack-size to > > be in line with all the rest and have it accept bytes instead of MB. > > And of course I'd push such a change to be included in v1.7.0 along with > > the other incompatible fixes. > > While at it, also change --big-file-threshold that fast-import learnt the > other day...
Yup. WTF was I thinking when I did megabytes as the default unit on the command line...
-- Shawn.