Re: [PATCH] rebase: don't invoke the pager for each commit summary

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jan 30, 2010, 16:46 UTC
Message-ID: <201001301746.13620.markus.heidelberg@web.de>
In-Reply-To: <alpine.DEB.1.00.1001301746200.4985@pacific.mpi-cbg.de>

Johannes Schindelin, 2010-01-30:

Show 16 quoted lines

> Hi,
> 
> On Sat, 30 Jan 2010, Markus Heidelberg wrote:
> 
> > diff --git a/git-rebase.sh b/git-rebase.sh
> > index b5d9178..fb4fef7 100755
> > --- a/git-rebase.sh
> > +++ b/git-rebase.sh
> > @@ -86,7 +86,7 @@ continue_merge () {
> >  		fi
> >  	fi
> >  	test -z "$GIT_QUIET" &&
> > -	git log --format=%s -1 "$cmt"
> > +	GIT_PAGER='' git log --format=%s -1 "$cmt"
> 
> Would it not be better 'git --no-pager log [...]'?

That was my initial fix, but then I found this in line 519:

        GIT_PAGER='' git diff --stat --summary "$mb" "$onto"

and decided to keep consistency.

Don't know.

Markus