git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Implement pthread_cond_broadcast on Windows

From
Johannes Sixt <j6t@kdbg.org>
Date
Jan 30, 2010, 09:30 UTC
Message-ID
<201001301030.36395.j6t@kdbg.org>
In-Reply-To
<alpine.DEB.1.00.1001300328070.3749@intel-tinevez-2-302>
On Samstag, 30. Januar 2010, Johannes Schindelin wrote:
Show 21 quoted lines
> Hi,
>
> On Sat, 30 Jan 2010, Johannes Sixt wrote:
> > See http://www.cse.wustl.edu/~schmidt/win32-cv-1.html, section "The
> > SignalObjectAndWait solution". But note that this implementation does not
> > use SignalObjectAndWait (which is needed to achieve fairness, but we do
> > not need fairness).
> >
> > Note that our implementations of pthread_cond_broadcast and
> > pthread_cond_signal require that they are invoked with the mutex held
> > that is used in the pthread_cond_wait calls.
> >
> > Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> > ---
> >  Junio,
> >
> >  please queue this patch for 1.7.0-rc1 even though it has not undergone
> >  a lot of review - the result is better than a git that does not even
> >  build on Windows.
>
> As you Cc:ed the msysGit list, do you want this in 4msysgit.git, too?

I hope some clever people on the msysgit list can say aye or nay to this patch. If you intend to release an msysgit that contains 5b594f4 (Threaded grep), then you need *something*, otherwise the build fails. Whether you get that something via upstream or apply it directly is of course secondary, but I prefer the former. ;)

-- Hannes
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 10 in “threaded-grep cause msys build failure”
  1. Zoltán FüzesiJan 29, 2010
  2. Johannes SixtJan 29, 2010
  3. MSVC: Windows-native implementation of pthread_cond_broadcastZoltán Füzesi, Jan 29, 2010
  4. Johannes SixtJan 29, 2010
  5. Windows: a minimal pthread_cond_broadcastJohannes Sixt, Jan 29, 2010
  6. Implement pthread_cond_broadcast on WindowsJohannes Sixt, Jan 29, 2010
  7. Johannes SchindelinJan 30, 2010
  8. Johannes SixtJan 30, 2010
  9. Johannes SchindelinJan 30, 2010
  10. Johannes SchindelinJan 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.