Re: [PATCH] bash: don't offer remote transport helpers as subcommands

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 28, 2010, 15:19 UTC
Message-ID: <20100128151951.GB20185@spearce.org>
In-Reply-To: <1264157691-27187-1-git-send-email-szeder@ira.uka.de>

SZEDER G??bor <szeder@ira.uka.de> wrote:

Show 12 quoted lines

> Since commits a2d725b7 (Use an external program to implement fetching
> with curl, 2009-08-05) and c9e388bb (Make the
> "traditionally-supported" URLs a special case, 2009-09-03) remote
> transport helpers like 'remote-ftp' and 'remote-curl' are offered by the
> completion script as available subcommands.  Not good, since they are
> helpers, therefore should not be offered, so filter them out.
> 
> Signed-off-by: SZEDER G??bor <szeder@ira.uka.de>
> ---
> 
> Maybe maint-worthy?  1.6.5 was the first release with this bug, but
> nobody complained since then.

Yup, should be in maint.

Acked-by: Shawn O. Pearce <spearce@spearce.org>

Show 17 quoted lines

>  contrib/completion/git-completion.bash |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 9651720..7def62c 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -568,6 +568,7 @@ __git_list_porcelain_commands ()
>  		read-tree)        : plumbing;;
>  		receive-pack)     : plumbing;;
>  		reflog)           : plumbing;;
> +		remote-*)         : transport;;
>  		repo-config)      : deprecated;;
>  		rerere)           : plumbing;;
>  		rev-list)         : plumbing;;
> -- 
> 1.6.6.1.361.gc5121

-- 
Shawn.