Re: [PATCH] bash: support 'git notes' and its subcommands

From: SZEDER Gábor <szeder@fzi.de>
Date: Jan 28, 2010, 03:30 UTC
Message-ID: <20100128033039.GB15202@neumann>
In-Reply-To: <201001280223.35625.johan@herland.net>

Hi Johan,

On Thu, Jan 28, 2010 at 02:23:35AM +0100, Johan Herland wrote:

Show 11 quoted lines

> On Thursday 28 January 2010, SZEDER Gábor wrote:
> > ... and it will offer refs unless after -m or -F, because these two
> > options require a non-ref argument.
> 
> Maybe-NAK.
> 
> The patch is probably good in itself, and the intent is certainly good, but 
> we're currently discussing deprecating the -m/-F options to "git notes edit" 
> (see http://article.gmane.org/gmane.comp.version-control.git/138215), and if 
> that's where we go, there's no point "encouraging" their use by adding bash-
> completions for them...

-m and -F are not encouraged, because they are not offered (short options in general are never offered by the completion script). However, their presence or absence is taken into account to offer something sensible: refs after 'git notes edit <TAB>', files after 'git notes edit -F <TAB>'. Note, that I chose 'edit' here, because currently it's the only subcommand taking '-F', but it will actually work the same way with the upcoming 'add' and 'append' subcommands.

Best, Gábor

[btw, Shawn, could you have a look at http://article.gmane.org/gmane.comp.version-control.git/137754 ?]