Re: [PATCH not-for-mainline] Implement git-vcs-p4

From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Jan 27, 2010, 15:56 UTC
Message-ID: <20100127155636.GA18210@Knoppix>
In-Reply-To: <1a6be5fa1001270318h4ac8ac3bnaba48787a5b3efa6@mail.gmail.com>

On Wed, Jan 27, 2010 at 12:18:35PM +0100, Tor Arvid Lund wrote:

Show 18 quoted lines

> Then, I did 'git fetch', and got a seg fault. I got around it by
> commenting out a line:
> 
> diff --git a/transport.c b/transport.c
> index 7714fdb..5b404f7 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -924,7 +924,7 @@ struct transport *transport_get(struct remote
> *remote, const char *url)
>         ret->url = url;
> 
>         /* In case previous URL had helper forced, reset it. */
> -       remote->foreign_vcs = NULL;
> +/*     remote->foreign_vcs = NULL;*/
> 
>         /* maybe it is a foreign URL? */
>         if (url) {
>

Hmm... And just commenting out that line will break case if you have push URL using remote helpers and second one for same remote that doesn't.

I'll look into that issue.

-Ilari