Re: [PATCH] Handle UNC paths everywhere

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Jan 25, 2010, 09:58 UTC
Message-ID: <201001251058.22714.robin.rosenberg@dewire.com>
In-Reply-To: <fabb9a1e1001250136n2fb0043av7348db9177f4d096@mail.gmail.com>

måndagen den 25 januari 2010 10.36.59 skrev  Sverre Rabbelier:

Show 10 quoted lines

> Heya,
> 
> On Mon, Jan 25, 2010 at 01:55, Robin Rosenberg
> 
> <robin.rosenberg@dewire.com> wrote:
> > In Windows paths beginning with // are knows as UNC paths. They are
> > absolute paths, usually referring to a shared resource on a server.
> 
> Cute, but will it actually work? I've tried to use them // paths on
> windows before with MSysGit, and it's never worked, probably due to

Works here (tm). Latest msygit + rebuilt git binaries on Windows 2003.

The only program I know in the msysgit installation that didn't accept UNC paths prior to this patch was in fact git.

> the same reason why it doesn't work in the cmd prompt (whatever reason
> that may be).

Any code of the this form will of course not support UNC paths:

if (!has_drive_letter(path))
	boom();

-- robin