Re: [PATCH] Windows: Remove dependency on pthreadGC2.dll
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jan 24, 2010, 19:03 UTC
- Message-ID
- <201001242003.33703.j6t@kdbg.org>
- In-Reply-To
- <1264327830-4204-1-git-send-email-michael.lukashov@gmail.com>
On Sonntag, 24. Januar 2010, Michael Lukashov wrote:
> Commit 44626dc7 (MSVC: Windows-native implementation for subset > of threads API, 2010-01-15) introduces builtin replacement of > pthreadGC2.dll functionality, thus we can completely drop > dependency on this dll.
Duh! This means that when I tested above-mentioned patch, I actually was using pthread.h from msysgit instead of compat/win32/pthread.h, and didn't test it at all (note: MinGW version; MSVC was fine because it had the right includes all the time). This patch passes the test suite and a 'git gc --aggressive':
Acked-by: Johannes Sixt <j6t@kdbg.org>
-- Hannes