git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-apply.c: Skip filenames without enough components

From
AGAndreas Gruenbacher <agruen@suse.de>
Date
Jan 17, 2010, 02:44 UTC
Message-ID
<201001170344.34525.agruen@suse.de>
In-Reply-To
<7vr5ppa2st.fsf@alter.siamese.dyndns.org>
On Sunday 17 January 2010 03:22:10 am Junio C Hamano wrote:
> Tests?

Sure if you think it's worth a regression test ... "git apply -p2" of the following patch fails with "fatal: git diff header lacks filename information when removing 2 leading pathname components (line 6)" with the fix, and creates b/f without:

	diff --git a/f b/f
	new file mode 100644
	index 0000000..6a69f92
	--- /dev/null
	+++ b/f
	@@ -0,0 +1 @@
	+f

(Some earlier versions of git failed with "fatal: git apply: bad git-diff - inconsistent new filename on line 5" in this case.)

Andreas
Previous: Junio C HamanoNext: Nanako Shiraishi
Message 3 of 5 in “builtin-apply.c: Skip filenames without enough components”
  1. builtin-apply.c: Skip filenames without enough componentsAndreas Gruenbacher, Jan 17, 2010
  2. Junio C HamanoJan 17, 2010
  3. Andreas GruenbacherJan 17, 2010
  4. Nanako ShiraishiJan 18, 2010
  5. Andreas GruenbacherJan 18, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.