Re: [PATCH 1/7] gitweb: Load checking

From: Jakub Narebski <jnareb@gmail.com>
Date: Jan 13, 2010, 17:18 UTC
Message-ID: <201001131818.38703.jnareb@gmail.com>
In-Reply-To: <1263374828-15342-2-git-send-email-warthog9@eaglescrag.net>

On Wed, 13 Jan 2010, John 'Warthog9' Hawley wrote:

> 
> v3 - warthog9: small additional adjustment to indicate where new load
>      checking should be added for future improvements
> v2 - Jakub: switching to using

"switching to using" what?

Show 5 quoted lines

> v1 - warthog9: Initial creation
> 
> Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---

Also, such comments should be put in the comment section, here i.e. between "---\n" separator and the diffstat, and not in the commit message.

>  gitweb/README      |    7 ++++++-
>  gitweb/gitweb.perl |   45 +++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 47 insertions(+), 5 deletions(-)

Other that this minor nick (which I guess could be fixed by Junio when applying), this one looks good.

-- 
Jakub Narebski
Poland