Re: [PATCH] git-p4: Fix empty submit template when editor fires up

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 10, 2010, 11:14 UTC
Message-ID: <20100110111440.GB19612@progeny.tock>
In-Reply-To: <20100110111153.GA19612@progeny.tock>

Jonathan Nieder wrote:

Show 7 quoted lines

> Kevin Leung wrote:
> > read_pipe() returns "\n". We need to remove it before passing it
> > to system().
> > 
> > Signed-off-by: Kevin Leung <kevinlsk@gmail.com>
> 
> If I understand correctly, this is a cosmetic change:

... and of course I didn't the subject. Sorry about that. Thanks for cleaning up my mess.

Acked-by: Jonathan Nieder <jrnieder@gmail.com>

> What is the rationale for the rewritten system() line?  I would have
> understood a change to
> 
> 	os.spawnlp("sh", "-c", editor + " \"$@\"", fileName)

I am still curious about this, though it is not so important.

Jonathan