Re: Filename quoting / parsing problem

From: Andreas Gruenbacher <agruen@suse.de>
Date: Jan 6, 2010, 00:04 UTC
Message-ID: <201001060104.25737.agruen@suse.de>
In-Reply-To: <201001022148.47841.agruen@suse.de>

On Saturday 02 January 2010 09:48:47 pm Andreas Gruenbacher wrote:

Show 5 quoted lines

> On Saturday 02 January 2010 07:37:08 pm Junio C Hamano wrote:
> > I don't think it happened in the GNU land yet, and you would be the
> > person to know about it ;-).
> 
> I'm working on it ...

The "experimental" branch [*] now has very lightly tested code for parsing most extended headers ("index", "rename from", "rename to", "copy from", "copy to", "old mode", "new mode", "deleted file mode", "new file mode"). Most things should work, except:

 * Doesn't parse filenames in "diff --git" lines.  (I tried to argue why
   those lines are a problem in this thread.)

 * sha1 checksums are not verified right now.  I'm not sure when that should
   happen: always by default, or only optionally?  (Like verifying file modes,
   this is going to surprise a lot of users.)

 * Similarity and dissimilarity headers are ignored.

 * Binary diffs are no supported.  I think GNU patch should recognize them and
   give a reasonable message for now.

[*] http://git.savannah.gnu.org/cgit/patch.git/log/?h=experimental

Can you guys please do something to make parsing of filenames in "diff --git" lines a lot easier, or unnecessary?

Thanks! Andreas