Re: [Updated PATCH 2/2] Improve transport helper exec failure reporting
On Thu, Dec 31, 2009 at 04:44:37PM +0100, Johannes Sixt wrote:
Show 5 quoted lines
> Ilari Liusvaara schrieb:
> >@@ -31,13 +31,19 @@ static struct child_process *get_helper(struct transport *transport)
>
> You should set helper->silent_exec_failure = 1 when you give your
> own error message for the ENOENT case.
Ah yeah, might matter for Win32.
> BTW, which error message do you see without your change in this
> case? You only say "pretty much useless", but do not give an
> example.
git: 'remote-foo' is not a git-command. See 'git --help'.
And as first line of output, such thing is utterly confusing.
Show 6 quoted lines
> >+ else
> >+ die("Unable to run helper %s: %s", helper->argv[0],
> >+ strerror(errno));
>
> You shouldn't write an error message here because start_command has
> already reported the error.Its not printed on Unix.
-Ilari